Re: [PATCH] Make git-branch a builtin

From: Petr Baudis <pasky@suse.cz>
Date: Oct 23, 2006, 23:19 UTC
Message-ID: <20061023231940.GU20017@pasky.or.cz>
In-Reply-To: <20061023215506.GB8344@spearce.org>

Dear diary, on Mon, Oct 23, 2006 at 11:55:06PM CEST, I got a letter where Shawn Pearce <spearce@spearce.org> said that...

Show 22 quoted lines

> Lars Hjemli <hjemli@gmail.com> wrote:
> [snip]
> > ---
> >  Makefile         |    3 +-
> >  builtin-branch.c |  217 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  builtin.h        |    1 +
> >  git-branch.sh    |  131 --------------------------------
> >  git.c            |    1 +
> >  5 files changed, 221 insertions(+), 132 deletions(-)
> [snip]
> > diff --git a/git-branch.sh b/git-branch.sh
> > deleted file mode 100755
> > index 4379a07..0000000
> > --- a/git-branch.sh
> > +++ /dev/null
> > @@ -1,131 +0,0 @@
> [snip 131 lines]
> 
> Aside from compatability with non-Git tools...
> 
> Wouldn't it make more sense to just include the full SHA1 of the
> file we are deleting rather than the entire 131 line negative diff?

I think this way it's easier to review since you can check what is going away with the new stuff you introduce instead.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)