git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-cherry should show "+" instead of "-" and vice versa

From
APAndy Parkins <andyparkins@gmail.com>
Date
Oct 23, 2006, 19:03 UTC
Message-ID
<200610232003.08861.andyparkins@gmail.com>
In git-cherry.sh:
  if test -f "$patch/$2"
  then
    sign=-
  else
    sign=+
  fi
Documentation says 'If the change seems to be in the upstream, it is shown on
the standard output with prefix "+"', however the above does the reverse.  
When
the file $patch/$2 exists it is because the patch /is/ in upstream so the sign
should be "+".
Signed-off-by: Andy Parkins <andyparkins@gmail.com>
---
 git-cherry.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-cherry.sh b/git-cherry.sh
index 8832573..1cc48e8 100755
--- a/git-cherry.sh
+++ b/git-cherry.sh
@@ -71,9 +71,9 @@ do
 	then
 		if test -f "$patch/$2"
 		then
-			sign=-
-		else
 			sign=+
+		else
+			sign=-
 		fi
 		case "$verbose" in
 		t)
-- 
1.4.2.3
Next: Petr Baudis
Message 1 of 3 in “git-cherry should show "+" instead of "-" and vice versa”
  1. git-cherry should show "+" instead of "-" and vice versaAndy Parkins, Oct 23, 2006
  2. Petr BaudisOct 23, 2006
  3. Andy ParkinsOct 23, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.