Re: [PATCH] git-cherry should show "+" instead of "-" and vice versa

From: Petr Baudis <pasky@suse.cz>
Date: Oct 23, 2006, 19:33 UTC
Message-ID: <20061023193326.GS20017@pasky.or.cz>
In-Reply-To: <200610232003.08861.andyparkins@gmail.com>

Dear diary, on Mon, Oct 23, 2006 at 09:03:08PM CEST, I got a letter where Andy Parkins <andyparkins@gmail.com> said that...

Show 15 quoted lines

> In git-cherry.sh:
> 
>   if test -f "$patch/$2"
>   then
>     sign=-
>   else
>     sign=+
>   fi
> 
> Documentation says 'If the change seems to be in the upstream, it is shown on
> the standard output with prefix "+"', however the above does the reverse.  
> When
> the file $patch/$2 exists it is because the patch /is/ in upstream so the sign
> should be "+".
> Signed-off-by: Andy Parkins <andyparkins@gmail.com>

See also

	http://news.gmane.org/find-root.php?message_id=<Pine.LNX.4.58.0608071328200.22971@kivilampi-30.cs.helsinki.fi>

Did the documentation ever get fixed or noone cared enough? ;-)

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)