Re: gitweb: using quotemeta

From: Luben Tuikov <ltuikov@yahoo.com>
Date: Oct 7, 2006, 17:41 UTC
Message-ID: <20061007174121.44284.qmail@web31813.mail.mud.yahoo.com>
In-Reply-To: <200610071123.23654.jnareb@gmail.com>

--- Jakub Narebski <jnareb@gmail.com> wrote:

Show 17 quoted lines

> Junio C Hamano wrote:
> > Jakub Narebski <jnareb@gmail.com> writes:
> > 
> >> I'd rather add (and use) separate subroutine for quoting/escaping
> >> values in HTTP headers, or to be more exact for the filename part
> >> of HTTP header "Content-Disposition:". This way if we decide to
> >> not replace all characters outside US-ASCII in suggested filename
> >> to save with '?', but only qoublequote '"' and linefeed '\n' characters,
> >> or even implement RFC 2047 to do the encoding (of course if browsers
> >> can read it), we could do this in one place. 
> > 
> > Sounds sane.  quote_filename?
> 
> Luben Tuikov used  to_qtext  in
>   "[PATCH] gitweb: Convert Content-Disposition filenames into qtext"
>   Msg-ID: <20061006191801.68649.qmail@web31815.mail.mud.yahoo.com>
>   http://permalink.gmane.org/gmane.comp.version-control.git/28437

I think that people familiar with the RFC will be able to quickly recognize what this function does, after seeing "qtext" in the name of the function. After all, not only filenames can be qtext.

    Luben