gitweb: using quotemeta

From: Luben Tuikov <ltuikov@yahoo.com>
Date: Sep 28, 2006, 21:15 UTC
Message-ID: <20060928211600.97412.qmail@web31808.mail.mud.yahoo.com>

Commit ab41dfbfd4f3f9fedac71550027e9813b11abe3d introduces the use of quotemeta to quote the $filename of the snapshot. The commit message explains:

    Just in case filename contains end of line character.

But quotemeta quotes any characters not matching /A-Za-z_0-9/.
Which means that we get strings like this:
    
    linux\-2\.6\.git\-5c2d97cb31fb77981797fec46230ca005b865799\.tar\.gz

Is this the desired behavior? FWIW, the backslash character is not part of of the name, but ended up when the snapshot was written to the filesystem.

Thanks,
   Luben