git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Skip t3403 selftests if stdin is not a terminal

From
Gerrit Pape <pape@smarden.org>
Date
Sep 19, 2006, 17:04 UTC
Message-ID
<20060919170442.28169.qmail@e5754f1244ec85.315fe32.mid.smarden.org>
In-Reply-To
<7v3base3l5.fsf@assigned-by-dhcp.cox.net>
On Fri, Sep 15, 2006 at 11:19:02PM -0700, Junio C Hamano wrote:
Show 14 quoted lines
> Junio C Hamano <junkio@cox.net> writes:
> > Gerrit Pape <pape@smarden.org> writes:
> >> sh t3403-rebase-skip.sh </dev/null fails because stdin is not connected
> >> to a terminal, as in the Debian autobuild environment.  This disbales
> >> the test 3 and 7 in this case.
> >
> > Disabling these tests somehow feels as if you are shooting the
> > messenger who reports breakage of the commands they try to test.
> >
> > Is it expected that the git Porcelainish commands involved in
> > these particular tests not to work without terminal?  If not
> > maybe we should fix them, not the test.
> 
> How about this instead?

Yes, this is the better fix, I agree. The selftests work fine for me with this patch applied.

Thanks, Gerrit.
Previous: Junio C Hamano
Message 4 of 4 in “Skip t3403 selftests if stdin is not a terminal”
  1. Skip t3403 selftests if stdin is not a terminalGerrit Pape, Sep 15, 2006
  2. Junio C HamanoSep 16, 2006
  3. Junio C HamanoSep 16, 2006
  4. Gerrit PapeSep 19, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.