From: Gerrit Pape <pape@smarden.org>
Date: Tue, 19 Sep 2006 17:04:42 GMT
Subject: Re: [PATCH] Skip t3403 selftests if stdin is not a terminal
Message-ID: <20060919170442.28169.qmail@e5754f1244ec85.315fe32.mid.smarden.org>
In-Reply-To: <7v3base3l5.fsf@assigned-by-dhcp.cox.net>

On Fri, Sep 15, 2006 at 11:19:02PM -0700, Junio C Hamano wrote:
> Junio C Hamano <junkio@cox.net> writes:
> > Gerrit Pape <pape@smarden.org> writes:
> >> sh t3403-rebase-skip.sh </dev/null fails because stdin is not connected
> >> to a terminal, as in the Debian autobuild environment.  This disbales
> >> the test 3 and 7 in this case.
> >
> > Disabling these tests somehow feels as if you are shooting the
> > messenger who reports breakage of the commands they try to test.
> >
> > Is it expected that the git Porcelainish commands involved in
> > these particular tests not to work without terminal?  If not
> > maybe we should fix them, not the test.
> 
> How about this instead?

Yes, this is the better fix, I agree.  The selftests work fine for me
with this patch applied.

Thanks, Gerrit.