git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitweb: Fix mimetype_guess_file for files with multiple extensions

From
Jakub Narebski <jnareb@gmail.com>
Date
Sep 19, 2006, 11:57 UTC
Message-ID
<200609191357.03796.jnareb@gmail.com>
In-Reply-To
<20060919082925.GC31940@admingilde.org>

Fix getting correct mimetype for "blob_plain" view for files which have multiple extensions, e.g. foo.1.html; now only the last extension is used to find mimetype.

Noticed by Martin Waitz.
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
This is much simpler (and faster!) correction to the mentioned problem.
I just don't grok regular expressions, not completly.
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 01fae94..034cdf1 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1199,7 +1199,7 @@ sub mimetype_guess_file {
 	}
 	close(MIME);
 
-	$filename =~ /\.(.*?)$/;
+	$filename =~ /\.([^.]*)$/;
 	return $mimemap{$1};
 }
 
-- 
1.4.2.1
Previous: Martin WaitzNext: Junio C Hamano
Message 6 of 10 in “gitweb: use correct mime type even if filename has multiple dots.”
  1. gitweb: use correct mime type even if filename has multiple dots.Martin Waitz, Sep 16, 2006
  2. Jakub NarebskiSep 16, 2006
  3. Martin WaitzSep 17, 2006
  4. Jakub NarebskiSep 17, 2006
  5. Martin WaitzSep 19, 2006
  6. gitweb: Fix mimetype_guess_file for files with multiple extensionsJakub Narebski, Sep 19, 2006
  7. Junio C HamanoSep 17, 2006
  8. Jakub NarebskiSep 17, 2006
  9. Junio C HamanoSep 17, 2006
  10. Martin WaitzSep 19, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.