Re: [PATCH] gitweb: use correct mime type even if filename has multiple dots.

From: Martin Waitz <tali@admingilde.org>
Date: Sep 17, 2006, 07:51 UTC
Message-ID: <20060917075157.GY17042@admingilde.org>
In-Reply-To: <eehr7e$5i0$1@sea.gmane.org>

hoi :)

On Sat, Sep 16, 2006 at 11:44:52PM +0200, Jakub Narebski wrote:

Show 10 quoted lines

> Martin Waitz wrote:
> 
> > Match the last part of the filename agains the extention from the
> > mime database instead of insisting that it starts at the first dot.
> [...]
> > -     $filename =~ /\.(.*?)$/;
> > -     return $mimemap{$1};
> 
> Actually, that is non-greedy match, so the above code insist that 
> extension starts at the _last_ dot.

hmm, but it didn't work for me. I had filenames like "man/program.8.html" which got served as "text/html" with the old code.

Besides, the new code would cope with extentions that contain a dot itself.

Looking at /etc/mime.types, it only contains pcf.Z but perhaps it should also contain tar.gz or similiar.

Show 11 quoted lines

> 
> -- 
> Jakub Narebski
> Warsaw, Poland
> ShadeHawk on #git
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Martin Waitz