git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] Move color option parsing out of diff.c and into color.[ch]

From
Jeff King <peff@peff.net>
Date
Sep 8, 2006, 00:11 UTC
Message-ID
<20060908001132.GA18649@coredump.intra.peff.net>
In-Reply-To
<7vfyf3s01w.fsf@assigned-by-dhcp.cox.net>
On Thu, Sep 07, 2006 at 04:56:43PM -0700, Junio C Hamano wrote:
> Some school of programming teach us to start the function name
> at the beginning of the line, separate from its type.  They say
> that would make "grep '^parse_color'" to work better.

Hmm. I don't like that style either, I was just using it because I thought that was the git style (which must have been caused by seeing some other function(s) with the same style -- but grepping through, it looks like there are very few functions using it). I'll fix the patches, but will wait to resend until I hear other comments.

-Peff
Previous: Junio C Hamano
Message 3 of 3 in “Move color option parsing out of diff.c and into color.[ch]”
  1. 2/3 Move color option parsing out of diff.c and into color.[ch]Jeff King, Sep 7, 2006
  2. Junio C HamanoSep 7, 2006
  3. Jeff KingSep 8, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.