From: Jeff King Date: Fri, 08 Sep 2006 00:11:32 GMT Subject: Re: [PATCH 2/3] Move color option parsing out of diff.c and into color.[ch] Message-ID: <20060908001132.GA18649@coredump.intra.peff.net> In-Reply-To: <7vfyf3s01w.fsf@assigned-by-dhcp.cox.net> On Thu, Sep 07, 2006 at 04:56:43PM -0700, Junio C Hamano wrote: > Some school of programming teach us to start the function name > at the beginning of the line, separate from its type. They say > that would make "grep '^parse_color'" to work better. Hmm. I don't like that style either, I was just using it because I thought that was the git style (which must have been caused by seeing some other function(s) with the same style -- but grepping through, it looks like there are very few functions using it). I'll fix the patches, but will wait to resend until I hear other comments. -Peff