[PATCH 1/2] rev list add option accepting revision constraints on standard input
- From
Andy Whitcroft <apw@shadowen.org>
- Date
- Sep 5, 2006, 21:51 UTC
- Message-ID
- <20060905215157.GA29172@shadowen.org>
- In-Reply-To
- <44FDECD1.2090909@shadowen.org>
rev-list: add option accepting revision constraints on standard input
When we are generating packs to update remote repositories we want to supply as much information as possible about the revisions that already exist to rev-list in order optimise the pack as much as possible. We need to pass two revisions for each branch we are updating in the remote repository and one for each additional branch. Where the remote repository has numerous branches we can run out of command line space to pass them.
Add a --stdin flag which causes rev-list to additionally read its stdin stream and parse that for revision constraints.
Signed-off-by: Andy Whitcroft <apw@shadowen.org> ---
diff --git a/builtin-rev-list.c b/builtin-rev-list.c index 8437454..0303909 100644 --- a/builtin-rev-list.c +++ b/builtin-rev-list.c @@ -304,10 +304,30 @@ static void mark_edges_uninteresting(str } } +/* + * Parse revision information, filling in the "rev_info" structure, + * revisions are taken from stream. + */ +static void setup_revisions_stream(FILE *stream, struct rev_info *revs) +{ + char line[1000]; + const char *args[] = { 0, line, 0 }; + + while (fgets(line, sizeof(line), stream) != NULL) { + line[strlen(line) - 1] = 0; + + if (line[0] == '-') + die("options not supported in --stdin mode"); + + (void)setup_revisions(2, args, revs, NULL); + } +} + int cmd_rev_list(int argc, const char **argv, const char *prefix) { struct commit_list *list; int i; + int read_stdin = 0; init_revisions(&revs, prefix); revs.abbrev = 0; @@ -329,9 +349,15 @@ int cmd_rev_list(int argc, const char ** bisect_list = 1; continue; } + if (!strcmp(arg, "--stdin")) { + read_stdin = 1; + continue; + } usage(rev_list_usage); - } + if (read_stdin) + setup_revisions_stream(stdin, &revs); + if (revs.commit_format != CMIT_FMT_UNSPECIFIED) { /* The command line has a --pretty */ hdr_termination = '\n';