git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix a comparison bug in diff-delta.c

From
Pierre Habouzit <madcoder@debian.org>
Date
Aug 23, 2006, 14:31 UTC
Message-ID
<200608231631.12958.madcoder@debian.org>
In-Reply-To
<Pine.LNX.4.63.0608231542380.28360@wbgn013.biozentrum.uni-wuerzburg.de>
Le mer 23 août 2006 15:45, Johannes Schindelin a écrit :
Show 9 quoted lines
> Hi,
>
> On Wed, 23 Aug 2006, Pierre Habouzit wrote:
> > -	for (i = 4; (1 << i) < hsize && i < 31; i++);
> > +	for (i = 4; (1u << i) < hsize && i < 31; i++);
>
> The variable i never takes on the value 31 (or any higher value), so
> there is no bug here. Unless you port git to a system where an int
> has less than 32 bit.

that remains quite tasteless though, and maybe that patch can be integrated to the "cleanup" series I sent later today.

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org
Previous: Johannes Schindelin
Message 3 of 3 in “Fix a comparison bug in diff-delta.c”
  1. Fix a comparison bug in diff-delta.cPierre Habouzit, Aug 23, 2006
  2. Johannes SchindelinAug 23, 2006
  3. Pierre HabouzitAug 23, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.