From: Pierre Habouzit Date: Wed, 23 Aug 2006 14:31:10 GMT Subject: Re: [PATCH] Fix a comparison bug in diff-delta.c Message-ID: <200608231631.12958.madcoder@debian.org> In-Reply-To: Le mer 23 août 2006 15:45, Johannes Schindelin a écrit : > Hi, > > On Wed, 23 Aug 2006, Pierre Habouzit wrote: > > - for (i = 4; (1 << i) < hsize && i < 31; i++); > > + for (i = 4; (1u << i) < hsize && i < 31; i++); > > The variable i never takes on the value 31 (or any higher value), so > there is no bug here. Unless you port git to a system where an int > has less than 32 bit. that remains quite tasteless though, and maybe that patch can be integrated to the "cleanup" series I sent later today. -- ·O· Pierre Habouzit ··O madcoder@debian.org OOO http://www.madism.org