Re: [RFC] adding support for md5
- From
Shawn Pearce <spearce@spearce.org>
- Date
- Aug 23, 2006, 04:14 UTC
- Message-ID
- <20060823041453.GA25796@spearce.org>
- In-Reply-To
- <7vr6z9s376.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
> I personally am not interested in making this configurable at > all. The hashcmp() change on the other hand to abstract out 20 > was a good preparation, if we ever want to switch to longer > hashes we would know where to look.
What about all of those memcpy(a, b, 20)'s? :-)
I can see us wanting to support say SHA-128 or SHA-256 in a few years. Especially as processors get faster and better attacks are developed against SHA-1 such that its no longer really the best trade-off hash function available.
-- Shawn.