Re: [PATCH 5/5] git-instaweb: If firefox was not found, just print the URL

From: Eric Wong <normalperson@yhbt.net>
Date: Jul 26, 2006, 22:40 UTC
Message-ID: <20060726224049.GA16645@localdomain>
In-Reply-To: <Pine.LNX.4.63.0607261634200.29667@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 16 quoted lines

> 
> Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> ---
>  git-instaweb.sh |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/git-instaweb.sh b/git-instaweb.sh
> index 242b55e..340ab98 100755
> --- a/git-instaweb.sh
> +++ b/git-instaweb.sh
> @@ -245,4 +245,5 @@ esac
>  
>  start_httpd
>  test -z "$browser" && browser=echo
> +which "$browser" >/dev/null 2>&1 || browser=echo
>  $browser http://127.0.0.1:$port

>From what I hear, 'which' isn't portable on some platforms.

Now this isn't the only place 'which' is used in instaweb, and I've been meaning to get rid of the other 'which' call in there for a while, but I haven't had much time to devote to git the past few weeks. Help here would be good.

-- 
Eric Wong