threads / patch / 4992

patch, 5 partsgit-instaweb: If firefox was not found, just print the URL

Subject: [PATCH 5/5] git-instaweb: If firefox was not found, just print the URL

## tl;dr

3 messages between Jul 26, 2006 and Jul 27, 2006. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Johannes Schindelin· Jul 26, 2006, 14:34 UTC · lore

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
---
 git-instaweb.sh |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Show changes to git-instaweb.sh +1 −0

diff --git a/git-instaweb.sh b/git-instaweb.sh
index 242b55e..340ab98 100755
--- a/git-instaweb.sh
+++ b/git-instaweb.sh
@@ -245,4 +245,5 @@ esac
 
 start_httpd
 test -z "$browser" && browser=echo
+which "$browser" >/dev/null 2>&1 || browser=echo
 $browser http://127.0.0.1:$port

-- 
1.4.2.rc2.g6a4e

Eric Wong· Jul 26, 2006, 22:40 UTC · re: Johannes Schindelin · lore

Re: [PATCH 5/5] git-instaweb: If firefox was not found, just print the URL

Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 16 quoted lines

> 
> Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> ---
>  git-instaweb.sh |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/git-instaweb.sh b/git-instaweb.sh
> index 242b55e..340ab98 100755
> --- a/git-instaweb.sh
> +++ b/git-instaweb.sh
> @@ -245,4 +245,5 @@ esac
>  
>  start_httpd
>  test -z "$browser" && browser=echo
> +which "$browser" >/dev/null 2>&1 || browser=echo
>  $browser http://127.0.0.1:$port

>From what I hear, 'which' isn't portable on some platforms.

Now this isn't the only place 'which' is used in instaweb, and I've been meaning to get rid of the other 'which' call in there for a while, but I haven't had much time to devote to git the past few weeks. Help here would be good.

-- 
Eric Wong

Eric Wong· Jul 27, 2006, 01:12 UTC · re: Eric Wong · lore

Re: [PATCH 5/5] git-instaweb: If firefox was not found, just print the URL

Eric Wong <normalperson@yhbt.net> wrote:

Oops, I forgot to run offlineimap for a few hours and was desynced. Disregard my messages, thanks.

-- 
Eric Wong