Re: What's in git.git

From: Timo Hirvonen <tihirvon@gmail.com>
Date: Jun 25, 2006, 18:07 UTC
Message-ID: <20060625210724.934617c4.tihirvon@gmail.com>
In-Reply-To: <Pine.LNX.4.64.0606251033030.3747@g5.osdl.org>

Linus Torvalds <torvalds@osdl.org> wrote:

Show 11 quoted lines

> On Sun, 25 Jun 2006, Junio C Hamano wrote:
> > 
> >    Timo Hirvonen:
> >       Clean up diff.c
> 
> THIS IS CRAP!
> 
> Dammit, anybody who claims that casting a constant string to "(char *)" is 
> a _cleanup_ is doing something seriously wrong.
> 
> That's crap, crap, crap, CRAP!

Sorry. It got really annoying to skip over the same compiler warnings in vim's quickfix window many times. At that time I just wanted to focus on the code I was writing.

Show 11 quoted lines

> but THESE are total and utter CRAP:
> 
> -               mf->ptr = ""; /* does not matter */
> +               mf->ptr = (char *)""; /* does not matter */
> -                               s->data = "";
> +                               s->data = (char *)"";
> 
> and we're better off with the warning than with the new code.
> 
> I suspect that both could have been made to use NULL instead to indicate 
> that no pointer exists.

I'll look into this.

-- 
http://onion.dynserv.net/~timo/