From: Timo Hirvonen Date: Sun, 25 Jun 2006 18:07:24 GMT Subject: Re: What's in git.git Message-ID: <20060625210724.934617c4.tihirvon@gmail.com> In-Reply-To: Linus Torvalds wrote: > On Sun, 25 Jun 2006, Junio C Hamano wrote: > > > > Timo Hirvonen: > > Clean up diff.c > > THIS IS CRAP! > > Dammit, anybody who claims that casting a constant string to "(char *)" is > a _cleanup_ is doing something seriously wrong. > > That's crap, crap, crap, CRAP! Sorry. It got really annoying to skip over the same compiler warnings in vim's quickfix window many times. At that time I just wanted to focus on the code I was writing. > but THESE are total and utter CRAP: > > - mf->ptr = ""; /* does not matter */ > + mf->ptr = (char *)""; /* does not matter */ > - s->data = ""; > + s->data = (char *)""; > > and we're better off with the warning than with the new code. > > I suspect that both could have been made to use NULL instead to indicate > that no pointer exists. I'll look into this. -- http://onion.dynserv.net/~timo/