Re: git-1.4.0 make problems
- From
- Dennis Stosberg <dennis@stosberg.net>
- Date
- Jun 17, 2006, 13:09 UTC
- Message-ID
- <20060617130957.G199de590@leonov.stosberg.net>
- In-Reply-To
- <200606171016.k5HAGQ1D005560@grail.cba.csuohio.edu>
Michael Somos wrote:
Show 8 quoted lines
> A good suggestion, but I am a newbie as you can tell, and would prefer to > play in a sandbox for some time before I would attempt it. Of more concern > to me now is a failed test : > > > * FAIL 12: apply diff between 3 and 2 > > git-apply <diff.3-2 && diff frotz.2 frotz > > * failed 2 among 12 test(s) > > make[1]: *** [t4101-apply-nonl.sh] Error 1
I have seen this test failing on FreeBSD 5.3, too. FreeBSD comes with a version of "diff" which does not add the "\ No newline at end of file" remark. Maybe your "diff" is simply too old. In that case, it's not a serious problem because Git uses its own internal diff implementation.
The intention of this test is to test git-apply and not the system's "diff", so perhaps it should bring along all its patches and not rely on the system's "diff" to generate them...
Regards, Dennis