threads / discuss / 4541

Re: git-1.4.0 make problems

Subject: Re: git-1.4.0 make problems

## tl;dr

3 messages between Jun 17, 2006 and Jun 17, 2006.

replies: 2people: 3as markdown or json

Michael Somos· Jun 17, 2006, 10:16 UTC · lore

Rene Scharfe wrote :

> | tar: pax_global_header: Unknown file type 'g', extracted as normal

> You can ignore or delete that file.  It is a pax extended global header,

Yes, I knew I could ignore the file right away. I figured it was due to some new feature of GNU tar.

> was released on 2001-08-29, by the way.  May I ask what operating system
> and version you are using?

Mandrake 8,1 for i586. I had not encountered problems with GNU tar 1.13.22 before. A quick google showed this was not a rare problem, but nothing in the tarball for git-1.4.0 mentioned this problem. I understand that it may be a rare or nonexistant problem for the target audience of "git", but just a sentence or two would be enough clue to help out those who may need it.

> It took me a while to realize that your diffs are reversed.  It's too

Yes, unfortunately, I did reverse it, but even patch can handle that.

> A good first exercise would be to fetch the git repository, edit Makefile
> and commit your change, and then send a patch to this list -- all using

A good suggestion, but I am a newbie as you can tell, and would prefer to play in a sandbox for some time before I would attempt it. Of more concern to me now is a failed test :

> * FAIL 12: apply diff between 3 and 2
>        git-apply <diff.3-2 && diff frotz.2 frotz
> * failed 2 among 12 test(s)
> make[1]: *** [t4101-apply-nonl.sh] Error 1

All the other tests worked which is great. Thanks for your reply. Shalom, Michael

Dennis Stosberg· Jun 17, 2006, 13:09 UTC · re: Michael Somos · lore

Michael Somos wrote:

Show 8 quoted lines

> A good suggestion, but I am a newbie as you can tell, and would prefer to
> play in a sandbox for some time before I would attempt it. Of more concern
> to me now is a failed test :
> 
> > * FAIL 12: apply diff between 3 and 2
> >        git-apply <diff.3-2 && diff frotz.2 frotz
> > * failed 2 among 12 test(s)
> > make[1]: *** [t4101-apply-nonl.sh] Error 1

I have seen this test failing on FreeBSD 5.3, too. FreeBSD comes with a version of "diff" which does not add the "\ No newline at end of file" remark. Maybe your "diff" is simply too old. In that case, it's not a serious problem because Git uses its own internal diff implementation.

The intention of this test is to test git-apply and not the system's "diff", so perhaps it should bring along all its patches and not rely on the system's "diff" to generate them...

Regards, Dennis

Rene Scharfe· Jun 17, 2006, 22:11 UTC · re: Michael Somos · lore

Michael Somos wrote:

> A good suggestion, but I am a newbie as you can tell, and would prefer to
> play in a sandbox for some time before I would attempt it.

You already sent a diff in your first message, so you're not that much of a newbie. :-)

Thanks for telling us about your first encounter with git, by the way. Take your time, and have fun learning and using git!

René