git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] http-fetch: fix possible segfault

From
NHNick Hengeveld <nickh@reactrix.com>
Date
Jun 7, 2006, 05:22 UTC
Message-ID
<20060607052235.GA4000@reactrix.com>

Initialize an object request's slot to a safe value. A non-NULL value can cause a segfault if the request is aborted before it starts.

Signed-off-by: Nick Hengeveld <nickh@reactrix.com>
---
 http-fetch.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/http-fetch.c b/http-fetch.c
index 661c909..d3602b7 100644
--- a/http-fetch.c
+++ b/http-fetch.c
@@ -399,6 +399,7 @@ void prefetch(unsigned char *sha1)
 	snprintf(newreq->filename, sizeof(newreq->filename), "%s", filename);
 	snprintf(newreq->tmpfile, sizeof(newreq->tmpfile),
 		 "%s.temp", filename);
+	newreq->slot = NULL;
 	newreq->next = NULL;
 
 	if (object_queue_head == NULL) {
-- 
1.4.0.rc1.gf75c7-dirty
Message 1 of 1 in “http-fetch: fix possible segfault”
  1. http-fetch: fix possible segfaultNick Hengeveld, Jun 7, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.