threads / patch / 4418

patchhttp-fetch: fix possible segfault

Subject: [PATCH] http-fetch: fix possible segfault

## tl;dr

One message between Jun 7, 2006 and Jun 7, 2006. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Nick Hengeveld· Jun 7, 2006, 05:22 UTC · lore

Initialize an object request's slot to a safe value. A non-NULL value can cause a segfault if the request is aborted before it starts.

Signed-off-by: Nick Hengeveld <nickh@reactrix.com>
---
 http-fetch.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Show changes to http-fetch.c +1 −0
diff --git a/http-fetch.c b/http-fetch.c
index 661c909..d3602b7 100644
--- a/http-fetch.c
+++ b/http-fetch.c
@@ -399,6 +399,7 @@ void prefetch(unsigned char *sha1)
 	snprintf(newreq->filename, sizeof(newreq->filename), "%s", filename);
 	snprintf(newreq->tmpfile, sizeof(newreq->tmpfile),
 		 "%s.temp", filename);
+	newreq->slot = NULL;
 	newreq->next = NULL;
 
 	if (object_queue_head == NULL) {
-- 
1.4.0.rc1.gf75c7-dirty

← back to recent threads