Re: blame now knows -S

From: Fredrik Kuivinen <freku045@student.liu.se>
Date: Apr 8, 2006, 11:42 UTC
Message-ID: <20060408114240.GA10137@c165.ib.student.liu.se>
In-Reply-To: <7v1ww9loon.fsf@assigned-by-dhcp.cox.net>

On Fri, Apr 07, 2006 at 02:28:40AM -0700, Junio C Hamano wrote:

Show 10 quoted lines

> I've made a few changes to "git blame" myself:
> 
>  - fix breakage caused by recent revision walker reorganization;
>  - use built-in xdiff instead of spawning GNU diff;
>  - implement -S <ancestry-file> like annotate does.
> 
> Depending on the density of changes, it now appears that blame
> is 10%-30% faster than annotate.  I thought CVS emulator might
> be interested to give it a whirl..
>

Nice work!

There is another possible optimisation with respect to xdiff. Instead of producing the diff on the xdiff side and parsing the diff in blame.c, we could add another call back which just gets the relevant information from the hunk header. I don't know how much we would gain from this, but it might be worth a try.

- Fredrik