Re: [PATCH] parse_date(): fix parsing 03/10/2006

From: Andrew Morton <akpm@osdl.org>
Date: Apr 5, 2006, 06:16 UTC
Message-ID: <20060404231606.219a4cc5.akpm@osdl.org>
In-Reply-To: <7vodzg4l5n.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:

Show 12 quoted lines

>
> The comment associated with the date parsing code for three
>  numbers separated with slashes or dashes implied we wanted to
>  interpret using this order:
> 
>  	yyyy-mm-dd
>  	yyyy-dd-mm
>  	mm-dd-yy
>  	dd-mm-yy
> 
>  However, the actual code had the last two wrong, and making it
>  prefer dd-mm-yy format over mm-dd-yy.

But there was a second problem. Once the parsing had misbehaved, Len managed to create a commit which was six months in the future:

commit 8313524a0d466f451a62709aaedf988d8257b21c
Author: Bob Moore <robert.moore@intel.com>
Date:   Tue Oct 3 00:00:00 2006 -0400

    ACPI: ACPICA 20060310

Will your fix prevent that from happening? If not, perhaps some basic sanity checking might be appropriate.