Re: [PATCH 1/4] send-email: Change from Mail::Sendmail to Net::SMTP

From: Eric Wong <normalperson@yhbt.net>
Date: Mar 26, 2006, 00:54 UTC
Message-ID: <20060326005424.GA1773@localdomain>
In-Reply-To: <20060325235859.GO26071@mythryan2.michonline.com>

Ryan Anderson <ryan@michonline.com> wrote:

Show 14 quoted lines

> On Sat, Mar 25, 2006 at 02:43:30AM -0800, Eric Wong wrote:
> > Net::SMTP is in the base Perl distribution, so users are more
> > likely to have it.  Net::SMTP also allows reusing the SMTP
> > connection, so sending multiple emails is faster.
> 
> Overall, I like this set of cleanups, just one thing struck me as,
> "why?"
> 
> >  	if ($quiet) {
> > -		printf "Sent %s\n", $subject;
> > +		print "Sent $subject\n";
> 
> This seems to be a pointless change, and actually, might be long-term
> counterproductive.

Force of habit, I think. I originally rewrote that portion but thought I reverted it back to the way it was. Besides, it's even slightly faster this way :) It could still be faster(!) if I just printed a list (like below).

Show 9 quoted lines

> Assumption: Eventually, we're going to want to internationalize git.
> 
> If that is true, we'll eventually do something like this to lines like
> that:
> 	printf( gettext("Send %s\n"), $subject);
> 
> The alternative:
> 	print gettext("Send $subject\n");
> does not work.

print gettext('Send '),$subject,"\n";

Show 6 quoted lines

> (The line that xgettext will see is 'Send $subject\n', but when the
> program actually runs, gettext will see the interpolated version, which
> fails.)
> 
> Internationalization may still be a ways off, but I think we're reaching
> the point where it might be something we care to think about.

-- 
Eric Wong