Re: [PATCH 1/4] send-email: Change from Mail::Sendmail to Net::SMTP

From: Ryan Anderson <ryan@michonline.com>
Date: Mar 25, 2006, 23:58 UTC
Message-ID: <20060325235859.GO26071@mythryan2.michonline.com>
In-Reply-To: <11432834102700-git-send-email-normalperson@yhbt.net>

On Sat, Mar 25, 2006 at 02:43:30AM -0800, Eric Wong wrote:

> Net::SMTP is in the base Perl distribution, so users are more
> likely to have it.  Net::SMTP also allows reusing the SMTP
> connection, so sending multiple emails is faster.

Overall, I like this set of cleanups, just one thing struck me as, "why?"

>  	if ($quiet) {
> -		printf "Sent %s\n", $subject;
> +		print "Sent $subject\n";

This seems to be a pointless change, and actually, might be long-term counterproductive.

Assumption: Eventually, we're going to want to internationalize git.

If that is true, we'll eventually do something like this to lines like
that:
	printf( gettext("Send %s\n"), $subject);

The alternative:
	print gettext("Send $subject\n");
does not work.

(The line that xgettext will see is 'Send $subject\n', but when the program actually runs, gettext will see the interpolated version, which fails.)

Internationalization may still be a ways off, but I think we're reaching the point where it might be something we care to think about.

-- 
Ryan Anderson
  sometimes Pug Majere