git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] Teach git-blame about renames

From
Fredrik Kuivinen <freku045@student.liu.se>
Date
Mar 9, 2006, 07:30 UTC
Message-ID
<20060309073014.GA1500@c165.ib.student.liu.se>
In-Reply-To
<7v4q28h38p.fsf@assigned-by-dhcp.cox.net>
On Wed, Mar 08, 2006 at 04:27:02PM -0800, Junio C Hamano wrote:
Show 8 quoted lines
> > -static int compare_tree(struct tree *t1, struct tree *t2)
> > +int compare_tree(struct tree *t1, struct tree *t2)
> > ...
> > -static int same_tree_as_empty(struct tree *t1)
> > +int same_tree_as_empty(struct tree *t1)
> 
> Maybe the names are a bit too generic to be used as a global?
>

Yes.. maybe. They are quite general though. Any suggestions for better names? We could prefix everything in revision.h with "rev_" or something like that.

Thanks for the comments. I will send an updated patch series soon.
- Fredrik
Previous: Junio C Hamano
Message 6 of 6 in “Teach git-blame about renames”
  1. 0/3 Teach git-blame about renamesFredrik Kuivinen, Mar 8, 2006
  2. 1/3 Make it possible to not clobber object.util in sort_in_topological_orderFredrik Kuivinen, Mar 8, 2006
  3. 2/3 rev-lib: Make it easy to do rename trackingFredrik Kuivinen, Mar 8, 2006
  4. 3/3 blame: Rename detectionFredrik Kuivinen, Mar 8, 2006
  5. Junio C HamanoMar 9, 2006
  6. Fredrik KuivinenMar 9, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.