From: Fredrik Kuivinen <freku045@student.liu.se>
Date: Thu, 09 Mar 2006 07:30:14 GMT
Subject: Re: [PATCH 0/3] Teach git-blame about renames
Message-ID: <20060309073014.GA1500@c165.ib.student.liu.se>
In-Reply-To: <7v4q28h38p.fsf@assigned-by-dhcp.cox.net>

On Wed, Mar 08, 2006 at 04:27:02PM -0800, Junio C Hamano wrote:
> > -static int compare_tree(struct tree *t1, struct tree *t2)
> > +int compare_tree(struct tree *t1, struct tree *t2)
> > ...
> > -static int same_tree_as_empty(struct tree *t1)
> > +int same_tree_as_empty(struct tree *t1)
> 
> Maybe the names are a bit too generic to be used as a global?
> 

Yes.. maybe. They are quite general though. Any suggestions for better
names? We could prefix everything in revision.h with "rev_" or
something like that.


Thanks for the comments. I will send an updated patch series soon.

- Fredrik