Re: [PATCH] Handle branch names with slashes

From: Karl Hasselström <kha@treskal.com>
Date: Feb 27, 2006, 13:09 UTC
Message-ID: <20060227130917.GA22933@diana.vm.bytemark.co.uk>
In-Reply-To: <1141043391.3438.66.camel@pc1117>

On 2006-02-27 12:29:51 +0000, Catalin Marinas wrote:

Show 8 quoted lines

> On Mon, 2006-02-27 at 13:11 +0100, Karl Hasselström wrote:
>
> > There was a bug here after all: I just tried "stg pick
> > multi@kha/patches" (to pick a patch named "multi" from the branch
> > "kha/patches"), and StGIT tried to pick the patch from branch
> > "kha".
>
> I haven't applied your patch yet (too busy to properly review it).

And as I just demonstrated, it certainly needed reviewing! (Actually, I believe I said that back when I posted the patch, too.)

Show 8 quoted lines

> > Looking closer, I realized that the complete patch specification
> > syntax is "patchname@branchname/bottom", not
> > "patchname/bottom@branchname" as I had assumed. This is obviously
> > hard to reconcile with branch names containing /.
>
> I don't have any strong opinion on either. Maybe we should use the
> latter if it makes things easier for supporting branch names with
> /'s.

The problem is that the current from is better (bottom is a modifier to patch@branch, not just patch). And using the other form will break when someone decides that patches with slashes in their names are a good idea (not a joke).

Perhaps change /bottom to #bottom (making the complete form patchname@branchname#bottom), and for backward compatibility accept patchname@branchname/bottom as well when no branch called "branchname/bottom" exists.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle