Re: [PATCH] Handle branch names with slashes

From: Karl Hasselström <kha@treskal.com>
Date: Feb 27, 2006, 12:11 UTC
Message-ID: <20060227121108.GA22398@diana.vm.bytemark.co.uk>
In-Reply-To: <20060217042108.GB28114@diana.vm.bytemark.co.uk>

On 2006-02-17 05:21:08 +0100, Karl Hasselström wrote:

Show 14 quoted lines

> On 2006-02-17 16:01:10 +1300, Sam Vilain wrote:
>
> > Karl Hasselström wrote:
> >
> > > Let StGIT grok branch names with slashes in them. It used to
> > > fall flat on its face when confronted with them.
> > >
> > > I think I've covered all, or at least most cases, but there are
> > > probably some bugs left if you look hard enough.
> >
> > Does `stgit -r patchname/bottom` still work?
>
> Yes (if you mean 'stg diff -r ... ' :-). It's just branches that can
> have slashes in their names, not patches.

There was a bug here after all: I just tried "stg pick multi@kha/patches" (to pick a patch named "multi" from the branch "kha/patches"), and StGIT tried to pick the patch from branch "kha".

Looking closer, I realized that the complete patch specification syntax is "patchname@branchname/bottom", not "patchname/bottom@branchname" as I had assumed. This is obviously hard to reconcile with branch names containing /.

Thoughts?

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle