Re: [PATCH] git-svnimport.perl: fix for 'arg list too long...'
- From
- Sasha Khapyorsky <sashak@voltaire.com>
- Date
- Feb 2, 2006, 14:26 UTC
- Message-ID
- <20060202142638.GD32188@sashak.voltaire.com>
- In-Reply-To
- <7v3bj27kxe.fsf@assigned-by-dhcp.cox.net>
On 14:50 Wed 01 Feb , Junio C Hamano wrote:
Show 5 quoted lines
> > *1* I do not think this makes much of a difference but here is what > I mean. > > diff --git a/git-svnimport.perl b/git-svnimport.perl
Tested. Works good. I think your version is cleaner. Cosmetic comment btw:
Show 5 quoted lines
> + open my $F, "|-", > + qw(git-update-index --force-remove -z --stdin) > + or die $!; > + print $F "$_\0" for @u; > + close $F or die $!;
It is not critical, but this block may be under if(@u) {..} to prevent "empty" git-update-index invocations.
Sasha.