git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] rev-{list,parse}: allow -n<n> as shorthand for --max-count=<n>

From
EWEric Wong <normalperson@yhbt.net>
Date
Jan 30, 2006, 00:26 UTC
Message-ID
<20060130002640.GC15482@Muzzle>
In-Reply-To
<20060130002501.GB15482@Muzzle>

Both -n<n> and -n <n> are supported. POSIX versions of head(1) and tail(1) allow their line limits to be parsed this way. I find --max-count to be a commonly used option, and also similar in spirit to head/tail, so I decided to make life easier on my worn out (and lazy :) fingers with this patch.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
 rev-list.c  |   10 ++++++++++
 rev-parse.c |   15 +++++++++++++++
 2 files changed, 25 insertions(+), 0 deletions(-)
a7f5327966f8ccdf887f3c63db3147135ff20983
diff --git a/rev-list.c b/rev-list.c
index 0b142c1..4565755 100644
--- a/rev-list.c
+++ b/rev-list.c
@@ -749,6 +749,16 @@ int main(int argc, const char **argv)
 		struct commit *commit;
 		unsigned char sha1[20];
 
+		if (!strcmp(arg, "-n")) {
+			if (++i >= argc)
+				die("-n requires an argument");
+			max_count = atoi(argv[i]);
+			continue;
+		}
+		if (!strncmp(arg,"-n",2)) {
+			max_count = atoi(arg + 2);
+			continue;
+		}
 		if (!strncmp(arg, "--max-count=", 12)) {
 			max_count = atoi(arg + 12);
 			continue;
diff --git a/rev-parse.c b/rev-parse.c
index d2f0864..3c99a79 100644
--- a/rev-parse.c
+++ b/rev-parse.c
@@ -165,6 +165,21 @@ int main(int argc, char **argv)
 			show_file(arg);
 			continue;
 		}
+		if (!strcmp(arg,"-n")) {
+			if (++i >= argc)
+				die("-n requires an argument");
+			if ((filter & DO_FLAGS) && (filter & DO_REVS)) {
+				show(arg);
+				show(argv[i]);
+			}
+			continue;
+		}
+		if (!strncmp(arg,"-n",2)) {
+			if ((filter & DO_FLAGS) && (filter & DO_REVS))
+				show(arg);
+			continue;
+		}
+
 		if (*arg == '-') {
 			if (!strcmp(arg, "--")) {
 				as_is = 1;
-- 
1.1.5.ga7f5-dirty
Previous: Eric Wong
Message 11 of 11 in “rev-{list,parse}: allow -<n> as shorthand for --max-count=<n>”
  1. rev-{list,parse}: allow -<n> as shorthand for --max-count=<n>Eric Wong, Jan 24, 2006
  2. Junio C HamanoJan 24, 2006
  3. Eric WongJan 25, 2006
  4. Junio C HamanoJan 25, 2006
  5. rev-{list,parse}: allow -n<n> as shorthand for --max-count=<n>Eric Wong, Jan 29, 2006
  6. rev-{list,parse}: optionally allow -<n> as shorthand for --max-count=<n>Eric Wong, Jan 29, 2006
  7. Junio C HamanoJan 29, 2006
  8. rev-{list,parse}: allow -<n> as shorthand for --max-count=<n>Eric Wong, Jan 30, 2006
  9. Junio C HamanoJan 29, 2006
  10. Eric WongJan 30, 2006
  11. rev-{list,parse}: allow -n<n> as shorthand for --max-count=<n>Eric Wong, Jan 30, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.