git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rev-{list,parse}: allow -n<n> as shorthand for --max-count=<n>

From
EWEric Wong <normalperson@yhbt.net>
Date
Jan 30, 2006, 00:25 UTC
Message-ID
<20060130002501.GB15482@Muzzle>
In-Reply-To
<7vbqxukcyo.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
Show 21 quoted lines
> Eric Wong <normalperson@yhbt.net> writes:
> 
> > Both -n<n> and -n <n> are supported.  POSIX versions of head(1) and
> > tail(1) allow their line limits to be parsed this way.  I find
> > --max-count to be a commonly used option, and also similar in spirit to
> > head/tail, so I decided to make life easier on my worn out (and lazy :)
> > fingers with this patch.
> 
> I agree with this in principle.
> 
> > diff --git a/rev-parse.c b/rev-parse.c
> > index 7abad35..3790463 100644
> > --- a/rev-parse.c
> > +++ b/rev-parse.c
> > @@ -21,6 +21,7 @@ static char *def = NULL;
> >  static int show_type = NORMAL;
> >  static int symbolic = 0;
> >  static int output_sq = 0;
> > +static int next_arg_is_rev = 0;
> 
> Do you need this here, or can it be made auto in main()?

Oops, I had changes in is_rev_argument() that I eventually moved entirely to main(). Cleaned up patch on the way.

-- 
Eric Wong
Previous: Junio C HamanoNext: Eric Wong
Message 10 of 11 in “rev-{list,parse}: allow -<n> as shorthand for --max-count=<n>”
  1. rev-{list,parse}: allow -<n> as shorthand for --max-count=<n>Eric Wong, Jan 24, 2006
  2. Junio C HamanoJan 24, 2006
  3. Eric WongJan 25, 2006
  4. Junio C HamanoJan 25, 2006
  5. rev-{list,parse}: allow -n<n> as shorthand for --max-count=<n>Eric Wong, Jan 29, 2006
  6. rev-{list,parse}: optionally allow -<n> as shorthand for --max-count=<n>Eric Wong, Jan 29, 2006
  7. Junio C HamanoJan 29, 2006
  8. rev-{list,parse}: allow -<n> as shorthand for --max-count=<n>Eric Wong, Jan 30, 2006
  9. Junio C HamanoJan 29, 2006
  10. Eric WongJan 30, 2006
  11. rev-{list,parse}: allow -n<n> as shorthand for --max-count=<n>Eric Wong, Jan 30, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.