Re: [PATCH 1/7] Add a minimal test for git-cherry

From: Yann Dirson <ydirson@altern.org>
Date: Jan 8, 2006, 09:58 UTC
Message-ID: <20060108095843.GD32585@nowhere.earth>
In-Reply-To: <7vy81r5ugx.fsf@assigned-by-dhcp.cox.net>

On Sat, Jan 07, 2006 at 06:22:54PM -0800, Junio C Hamano wrote:

Show 18 quoted lines

> Yann Dirson <ydirson@altern.org> writes:
> 
> > This test checks that git-cherry finds the expected number of patches
> > in two simple cases.
> >
> > Signed-off-by: Yann Dirson <ydirson@altern.org>
> >
> > +test_expect_success \
> > +    'cherry-pick one of the 2 patches, and check cherry recognized one and only one as new' \
> > +    'git-cherry-pick my-topic-branch^0 &&
> > +     echo $(git-cherry master my-topic-branch) &&
> > +     expr "$(echo $(git-cherry master my-topic-branch) )" : "+ [^ ]* - .*"
> > +'
> 
> I wonder if "+ followed by -" order is stable here.  If you make
> commits in the my-topic-branch fast enough, they would get the
> same timestamp and I suspect the order from rev-list would be
> left to chance.

We could maybe insert a sleep between the two commits ? Not that I find it too appealing, however...

-- 
Yann Dirson    <ydirson@altern.org> |
Debian-related: <dirson@debian.org> |   Support Debian GNU/Linux:
                                    |  Freedom, Power, Stability, Gratis
     http://ydirson.free.fr/        | Check <http://www.debian.org/>