Re: [PATCH] close clobbers mmap's errno in read_cache

From: Alex Riesen <raa.lkml@gmail.com>
Date: Oct 7, 2005, 23:50 UTC
Message-ID: <20051007235011.GA8189@steel.home>
In-Reply-To: <20051007214845.GH8383MdfPADPa@greensroom.kotnet.org>

Sven Verdoolaege, Fri, Oct 07, 2005 23:48:45 +0200:

Show 10 quoted lines

> On Fri, Oct 07, 2005 at 11:45:51PM +0200, Alex Riesen wrote:
> >  	}
> > +	i = errno;
> >  	close(fd);
> >  	if (map == MAP_FAILED)
> > -		die("index file mmap failed (%s)", strerror(errno));
> > +		die("index file mmap failed (%s)", strerror(i));
> >  
> 
> Why don't you just move the close after the test ?

I don't know.

> There's no point in closing if you're going to die.
> 
> skimo

Of course you're right :) I'm just blind after eight.