git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] close clobbers mmap's errno in read_cache

From
Alex Riesen <raa.lkml@gmail.com>
Date
Oct 7, 2005, 21:45 UTC
Message-ID
<20051007214551.GA8893@steel.home>
Save errno before close(fd) for strerror in die().
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
--- a/read-cache.c	2005-10-03 09:16:31.000000000 +0200
+++ b/read-cache.c	2005-10-07 23:23:40.000000000 +0200
@@ -482,9 +482,10 @@ int read_cache(void)
 		if (size >= sizeof(struct cache_header) + 20)
 			map = mmap(NULL, size, PROT_READ | PROT_WRITE, MAP_PRIVATE, fd, 0);
 	}
+	i = errno;
 	close(fd);
 	if (map == MAP_FAILED)
-		die("index file mmap failed (%s)", strerror(errno));
+		die("index file mmap failed (%s)", strerror(i));
 
 	hdr = map;
 	if (verify_hdr(hdr, size) < 0)
Next: Sven Verdoolaege
Message 1 of 3 in “close clobbers mmap's errno in read_cache”
  1. close clobbers mmap's errno in read_cacheAlex Riesen, Oct 7, 2005
  2. Sven VerdoolaegeOct 7, 2005
  3. Alex RiesenOct 7, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.