Re: [PATCH 1/3] Support for SSL client cert
- From
Petr Baudis <pasky@suse.cz>
- Date
- Sep 26, 2005, 18:23 UTC
- Message-ID
- <20050926182341.GA26340@pasky.or.cz>
- In-Reply-To
- <20050926175156.GB9410@reactrix.com>
Dear diary, on Mon, Sep 26, 2005 at 07:51:57PM CEST, I got a letter where Nick Hengeveld <nickh@reactrix.com> told me that...
Show 21 quoted lines
> @@ -491,11 +495,19 @@ int main(int argc, char **argv)
> } else if (argv[arg][1] == 'w') {
> write_ref = argv[arg + 1];
> arg++;
> + } else if (arg+1 < argc && !strcmp(argv[arg], "--cert")) {
> + ssl_cert = argv[++arg];
> + } else if (arg+1 < argc && !strcmp(argv[arg], "--key")) {
> + ssl_key = argv[++arg];
> + } else if (arg+1 < argc && !strcmp(argv[arg], "--capath")) {
> + ssl_capath = argv[++arg];
> + } else if (arg+1 < argc && !strcmp(argv[arg], "--cacert")) {
> + ssl_cacert = argv[++arg];
> }
> arg++;
> }
> if (argc < arg + 2) {
> - usage("git-http-fetch [-c] [-t] [-a] [-d] [-v] [--recover] [-w ref] commit-id url");
> + usage("git-http-fetch [-c] [-t] [-a] [-d] [-v] [--recover] [-w ref] [--cert ssl-cert-file] [--key ssl-key-file] [--capath CA-dir] [--cacert CA-cert-file] commit-id url");
> return 1;
> }
> commit_id = argv[arg];Could we please have at least --sslkey, if not having 'ssl' prepended to all of them? You never know when you'll want to call something else like that in the future... ;-)
-- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ VI has two modes: the one in which it beeps and the one in which it doesn't.