git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 5/6] Fix "git-local-fetch -s" with packed source repository

From
Sergey Vlasov <vsu@altlinux.ru>
Date
Sep 23, 2005, 12:28 UTC
Message-ID
<20050923122833.49AD2E010FC@center4.mivlgu.local>
In-Reply-To
<20050923122754.GB2197@master.mivlgu.local>

"git-local-fetch -s" did not work with a packed repository, because symlink() happily created a link to a non-existing object file, therefore fetch_file() always returned success, and fetch_pack() was not called. Fixed by calling stat() before symlink() to ensure the file really exists.

Signed-off-by: Sergey Vlasov <vsu@altlinux.ru>
---
 local-fetch.c |   14 +++++++++++---
 1 files changed, 11 insertions(+), 3 deletions(-)
40d9d7c0c86ee790a330f2fb3e1355bde4e9d434
diff --git a/local-fetch.c b/local-fetch.c
--- a/local-fetch.c
+++ b/local-fetch.c
@@ -65,9 +65,17 @@ static int copy_file(const char *source,
 			return -1;
 		}
 	}
-	if (use_symlink && !symlink(source, dest)) {
-		pull_say("symlink %s\n", hex);
-		return 0;
+	if (use_symlink) {
+		struct stat st;
+		if (stat(source, &st)) {
+			fprintf(stderr, "cannot stat %s: %s\n", source,
+				strerror(errno));
+			return -1;
+		}
+		if (!symlink(source, dest)) {
+			pull_say("symlink %s\n", hex);
+			return 0;
+		}
 	}
 	if (use_filecopy) {
 		int ifd, ofd, status;
Previous: Sergey VlasovNext: Sergey Vlasov
Message 6 of 7 in “More fetch fixes”
  1. 0/6 More fetch fixesSergey Vlasov, Sep 23, 2005
  2. 1/6 fetch.c: Do not build object ref listsSergey Vlasov, Sep 23, 2005
  3. 2/6 fetch.c: Plug memory leak in process_tree()Sergey Vlasov, Sep 23, 2005
  4. 3/6 git-local-fetch: Fix error checking and leak in setup_indices()Sergey Vlasov, Sep 23, 2005
  5. 4/6 git-local-fetch: Avoid calling close(-1)Sergey Vlasov, Sep 23, 2005
  6. 5/6 Fix "git-local-fetch -s" with packed source repositorySergey Vlasov, Sep 23, 2005
  7. 6/6 git-local-fetch: Avoid confusing error messages on packed repositoriesSergey Vlasov, Sep 23, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.