[PATCH 3/6] git-local-fetch: Fix error checking and leak in setup_indices()

From

Sergey Vlasov <vsu@altlinux.ru>

Date

Sep 23, 2005, 12:28 UTC

Message-ID

<20050923122823.3D01BE010FC@center4.mivlgu.local>

In-Reply-To

<20050923122754.GB2197@master.mivlgu.local>

Signed-off-by: Sergey Vlasov <vsu@altlinux.ru>

---

 local-fetch.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

b2c9aab8c8186900cc4610e144513d45fc5b4865

diff --git a/local-fetch.c b/local-fetch.c
--- a/local-fetch.c
+++ b/local-fetch.c
@@ -38,6 +38,8 @@ static int setup_indices(void)
 	unsigned char sha1[20];
 	sprintf(filename, "%s/objects/pack/", path);
 	dir = opendir(filename);
+	if (!dir)
+		return -1;
 	while ((de = readdir(dir)) != NULL) {
 		int namelen = strlen(de->d_name);
 		if (namelen != 50 || 
@@ -46,6 +48,7 @@ static int setup_indices(void)
 		get_sha1_hex(de->d_name + 5, sha1);
 		setup_index(sha1);
 	}
+	closedir(dir);
 	return 0;
 }