Re: [PATCH 0/2] Update git-send-email-script with --compose

From: Ryan Anderson <ryan@michonline.com>
Date: Sep 5, 2005, 15:37 UTC
Message-ID: <20050905153705.GD5335@mythryan2.michonline.com>
In-Reply-To: <46a038f905090504166246dc0a@mail.gmail.com>

On Mon, Sep 05, 2005 at 11:16:57PM +1200, Martin Langhoff wrote:

Show 8 quoted lines

> Ryan,
> 
> is it possible to fix the git-send-email script to "just work" reading
> in the emails that `git-format-patch-script -o patchdir origin`
> generates? I have a very ugly local patch to git-send-email-script
> that
> 
>  - reads "from" from git-var, can be overridden by passing an explicit --from

git-send-email-script already reads the "From:" from git-var - but I suppose I should only *prompt* for the from if something isn't satisfactory with the output of git-var. TODO #1

>  - reads "subject" from the first line of STDIN or file. If the line
> doesn't start with [PATCH it provides the [PATCH] prefix. I found it
> really confusing that it wants to get 'from' in the first line...
> that's not what git-format-patch produces!

Sorry about that - I always export using git-format-patch using --mbox, and those work nicely. I'm a bit reluctant to do the [PATCH] fixup, but I think I will:

	1. Detect [PATCH] or [PATCH [0-9]+/[0-9]+] (Sorry for the horrid
	fake-regexp)
	2. Provide a --no-fixup-subject to turn that off.

(TODO #2)

>  - it never prompts for anything

I think I'm tending in that direction - I'll keep making the prompting a fall-back by adding better default detection.

In this case, remember that this was an attempt to help users patch bomb lists, getting all the subtle details correct. The prompting is there to help get the subtle details correct!

Show 8 quoted lines

> I then invoke it with 
> 
>   git-send-email-script --to git@vger.kernel.org patches/0001-bad-uglypatch
> 
> and it "just works". I haven't sent them anywhere because I just
> wanted it to work locally for me, and it's just a bunch of hacks. And
> you are clearly using something other than git-format-patch to
> generate those patchfiles -- and my patches would break that.

Well, I'm not. Try "git format-patch --mbox -o patchdir origin" and see if that works better for you.

> OTOH, it'd be great if it did support the git-format-patch output. Let
> me know if you want bits and pieces of my hack - though it's trivial.

Sure, send it at me, and I'll see what I can incorporate.

I do apologize for not realizing that the default git format-patch output doesn't match what git send-email script expects the "legacy" mode - I'll sort that out one way or another as well. (TODO #3)

-- 
Ryan Anderson
  sometimes Pug Majere