git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/4] Plug memory leak in git-pack-objects

From
Sergey Vlasov <vsu@altlinux.ru>
Date
Aug 8, 2005, 18:46 UTC
Message-ID
<20050808184658.GE5789@procyon.home>
In-Reply-To
<20050808184332.GA5789@procyon.home>
[PATCH] Plug memory leak in git-pack-objects
find_deltas() should free its temporary objects before returning.
Signed-off-by: Sergey Vlasov <vsu@altlinux.ru>
---
 pack-objects.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
8b38f80b97affd0d9808b8f276a9e2e04bf03464
diff --git a/pack-objects.c b/pack-objects.c
--- a/pack-objects.c
+++ b/pack-objects.c
@@ -382,6 +382,10 @@ static void find_deltas(struct object_en
 		if (idx >= window)
 			idx = 0;
 	}
+
+	for (i = 0; i < window; ++i)
+		free(array[i].data);
+	free(array);
 }
 
 int main(int argc, char **argv)
Previous: Sergey Vlasov
Message 5 of 5 in “Plug some more memory leaks in git”
  1. 0/4 Plug some more memory leaks in gitSergey Vlasov, Aug 8, 2005
  2. 1/4 Plug memory leak in read_object_with_reference()Sergey Vlasov, Aug 8, 2005
  3. 2/4 Plug memory leak in write_sha1_to_fd()Sergey Vlasov, Aug 8, 2005
  4. 3/4 Plug memory leak in sha1close()Sergey Vlasov, Aug 8, 2005
  5. 4/4 Plug memory leak in git-pack-objectsSergey Vlasov, Aug 8, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.