git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/4] Plug memory leak in read_object_with_reference()

From
Sergey Vlasov <vsu@altlinux.ru>
Date
Aug 8, 2005, 18:44 UTC
Message-ID
<20050808184443.GB5789@procyon.home>
In-Reply-To
<20050808184332.GA5789@procyon.home>
[PATCH] Plug memory leak in read_object_with_reference()

When following a reference, read_object_with_reference() did not free the intermediate object data.

Signed-off-by: Sergey Vlasov <vsu@altlinux.ru>
---
 sha1_file.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
f7d16d6b83698fd7858ad28340b3e87780322261
diff --git a/sha1_file.c b/sha1_file.c
--- a/sha1_file.c
+++ b/sha1_file.c
@@ -1165,6 +1165,7 @@ void *read_object_with_reference(const u
 			free(buffer);
 			return NULL;
 		}
+		free(buffer);
 		/* Now we have the ID of the referred-to object in
 		 * actual_sha1.  Check again. */
 	}
Previous: Sergey VlasovNext: Sergey Vlasov
Message 2 of 5 in “Plug some more memory leaks in git”
  1. 0/4 Plug some more memory leaks in gitSergey Vlasov, Aug 8, 2005
  2. 1/4 Plug memory leak in read_object_with_reference()Sergey Vlasov, Aug 8, 2005
  3. 2/4 Plug memory leak in write_sha1_to_fd()Sergey Vlasov, Aug 8, 2005
  4. 3/4 Plug memory leak in sha1close()Sergey Vlasov, Aug 8, 2005
  5. 4/4 Plug memory leak in git-pack-objectsSergey Vlasov, Aug 8, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.