git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] Add git-send-email-script - tool to send emails from git-format-patch-script

From
RARyan Anderson <ryan@michonline.com>
Date
Jul 31, 2005, 23:54 UTC
Message-ID
<20050731235439.GI32263@mythryan2.michonline.com>
In-Reply-To
<Pine.LNX.4.58.0507311223240.16181@wgmdd8.biozentrum.uni-wuerzburg.de>
On Sun, Jul 31, 2005 at 12:25:13PM +0200, Johannes Schindelin wrote:
Show 6 quoted lines
> Hi,
> 
> wouldn't it be a good idea to make $from and $to required parameters? At
> least you could infer a sensible default of $from from GIT_* environment
> variables, no? I am not quite comfortable with a hard coded sender in a
> script possibly deployed into a multi-user environment.
The sender isn't hardcoded.

If it isn't sent on the command line, the return value from git-var -l is used to set a default, which is then confirmed by the ReadLine interface.

Some of the comments were leftover from Greg's original, before I remembered to remove them - it should be better now if you take another look. (See my, soon to be sent, set of additional changes.)

-- 
Ryan Anderson
  sometimes Pug Majere
Previous: Johannes SchindelinNext: Sergey Vlasov
Message 12 of 16 in “Add git-send-email-script - tool to send emails from git-format-patch-script”
  1. 1/3 Add git-send-email-script - tool to send emails from git-format-patch-scriptRyan Anderson, Jul 31, 2005
  2. Ryan AndersonJul 31, 2005
  3. Matthias UrlichsJul 31, 2005
  4. Junio C HamanoJul 31, 2005
  5. Junio C HamanoJul 31, 2005
  6. Ryan AndersonJul 31, 2005
  7. Junio C HamanoAug 1, 2005
  8. Matthias UrlichsAug 1, 2005
  9. Ryan AndersonAug 3, 2005
  10. Matthias UrlichsAug 3, 2005
  11. Johannes SchindelinJul 31, 2005
  12. Ryan AndersonJul 31, 2005
  13. Sergey VlasovJul 31, 2005
  14. Noel MaddyAug 2, 2005
  15. Junio C HamanoAug 2, 2005
  16. Noel MaddyAug 2, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.