From: Ryan Anderson Date: Sun, 31 Jul 2005 23:54:39 GMT Subject: Re: [PATCH 1/3] Add git-send-email-script - tool to send emails from git-format-patch-script Message-ID: <20050731235439.GI32263@mythryan2.michonline.com> In-Reply-To: On Sun, Jul 31, 2005 at 12:25:13PM +0200, Johannes Schindelin wrote: > Hi, > > wouldn't it be a good idea to make $from and $to required parameters? At > least you could infer a sensible default of $from from GIT_* environment > variables, no? I am not quite comfortable with a hard coded sender in a > script possibly deployed into a multi-user environment. The sender isn't hardcoded. If it isn't sent on the command line, the return value from git-var -l is used to set a default, which is then confirmed by the ReadLine interface. Some of the comments were leftover from Greg's original, before I remembered to remove them - it should be better now if you take another look. (See my, soon to be sent, set of additional changes.) -- Ryan Anderson sometimes Pug Majere