Re: [PATCH/RFC] "Recursive Make considered harmful"
- From
Petr Baudis <pasky@suse.cz>
- Date
- Jul 28, 2005, 07:51 UTC
- Message-ID
- <20050728075115.GB18907@pasky.ji.cz>
- In-Reply-To
- <42E8058B.7070907@gmail.com>
Dear diary, on Thu, Jul 28, 2005 at 12:07:07AM CEST, I got a letter where A Large Angry SCM <gitzilla@gmail.com> told me that...
Show 14 quoted lines
> Junio C Hamano wrote: > >While I do not have strong objections to make the build process > >go faster, it is somewhat disturbing that the Makefile pieces > >maintained in subdirectories need to name things they touch > >using paths that include the subdirectory names. I do not have > >a better alternative to suggest, though... > > For a project the size of Git, is there any real benefit to this change? > > Besides pathing issues, you also have to aware that all identifiers in > the included makefile fragments will be global. > > I don't object to the change but I see it as trading one maintenance > issue for another.
I'd also argue that generally, larger files are inherently harder to maintain, and having all the targets for all the subdirectories in a single file sounds nightmarish. (OTOH, by now you probably know that I'm a keep-it-as-local-as-possible junkie.)
-- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ If you want the holes in your knowledge showing up try teaching someone. -- Alan Cox