Re: [PATCH 2/2] GIT: Listen on IPv6 as well, if available.
In article <20050722212151.GI11916@pasky.ji.cz> (at Fri, 22 Jul 2005 23:21:51 +0200), Petr Baudis <pasky@suse.cz> says:
> this whole getaddrinfo() magic looks horribly complicated. What's wrong
> on just adding a similar code (or factoring it out to a function) for
> IPv6 as there is for IPv4, just s/INET/INET6/?
Because it is the Good Way To Go; protocol independent programming.
Show 7 quoted lines
> > - die("accept returned %s", strerror(errno));
> > + struct sockaddr_storage ss;
> > + socklen_t sslen = sizeof(ss);
>
> Perhaps move those to the most inner block. (All right, I'm nitpicking
> too much again, sorry.)
> Show 5 quoted lines
> > + if (select(maxfd + 1, &fds, NULL, NULL, NULL) == -1) {
> > + /* warning? */
>
> Certainly a warning and at least sleep(1) to avoid cpuburn-like
> behaviour in case of anything going wrong.YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org>