From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org>
Date: Fri, 22 Jul 2005 21:35:17 GMT
Subject: Re: [PATCH 2/2] GIT: Listen on IPv6 as well, if available.
Message-ID: <20050722.173517.73563363.yoshfuji@linux-ipv6.org>
In-Reply-To: <20050722212151.GI11916@pasky.ji.cz>

In article <20050722212151.GI11916@pasky.ji.cz> (at Fri, 22 Jul 2005 23:21:51 +0200), Petr Baudis <pasky@suse.cz> says:


> this whole getaddrinfo() magic looks horribly complicated. What's wrong
> on just adding a similar code (or factoring it out to a function) for
> IPv6 as there is for IPv4, just s/INET/INET6/?

Because it is the Good Way To Go; protocol independent programming.


> > -				die("accept returned %s", strerror(errno));
> > +		struct sockaddr_storage ss;
> > +		socklen_t sslen = sizeof(ss);
> 
> Perhaps move those to the most inner block. (All right, I'm nitpicking
> too much again, sorry.)
> 

okay.

> > +             if (select(maxfd + 1, &fds, NULL, NULL, NULL) == -1) {
> > +                     /* warning? */
> 
> Certainly a warning and at least sleep(1) to avoid cpuburn-like
> behaviour in case of anything going wrong.

okay...

--yoshfuji