Re: [PATCH 1/2] Introduce git-run-with-user-path helper program.

From: Petr Baudis <pasky@ucw.cz>
Date: May 17, 2005, 20:35 UTC
Message-ID: <20050517203500.GH7136@pasky.ji.cz>
In-Reply-To: <7vk6lxfybc.fsf@assigned-by-dhcp.cox.net>

Dear diary, on Tue, May 17, 2005 at 09:27:03PM CEST, I got a letter where Junio C Hamano <junkio@cox.net> told me that...

Show 29 quoted lines

> >>>>> "PB" == Petr Baudis <pasky@ucw.cz> writes:
> 
> >> +int path_ignored(const char *path)
> >> +{
> >> +	if (!verify_path(path))
> >> +		return 1;
> >> +
> >> +	/* Put the Porcelain layer ignore logic here.
> >> +	 * Return non-zero if path is to be ignored.
> >> +	 */
> >> +	return 0;
> >> +}
> 
> PB> I actually think you shouldn't. All the Porcelain layers should
> PB> hopefully use the same git toolkit layer, not each one shipping own due
> PB> to differences in things like this.
> 
> What you said above _is_ exactly my intention.  I phrased that
> comment very badly.  It should have said:
> 
>     /* We _will_ put the "ignore logic Porcelain layers agree upon"
>      * here, once we have a concensus.
>      *
>      * The code should return non-zero if path is to be ignored.
>      */
> 
> I did not put any implementation there because I do not think we
> have agreed upon anything yet.  This patch is to establish
> the framework.

Ok, so this just bad comment. :-) No problem then.

Regarding having the code in the library, well, I'm thinking about why not to just put this logic into all the git commands. Unfortunately I can't find the email with Linus' argumentation against that right now. :-(

> git-run-with-user-path is useful both in implementing
> porcelain-add if the porcelain's policy is to take filesystem
> paths not GIT paths, like this:

Actually, my doubts about general usefulness of this wrapper are growing. Cogito is unlikely to ever make use of it since it has to figure out the .git location anyway for own use (it keeps plenty of own files there). But that's likely what any other porcelain layer would have to do as well, isn't it? The wrapper could still be useful for the standalone users, though.

Another thing is, I don't think git-run-with-user-path is the right name. I think it doesn't make much sense on its own, and the wrapper is actually doing more anyway, applying the ignore rules. What about calling it just git-run-wrapper?

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor