Re: [PATCH 1/2] Introduce git-run-with-user-path helper program.
- From
Petr Baudis <pasky@ucw.cz>
- Date
- May 17, 2005, 19:03 UTC
- Message-ID
- <20050517190355.GA7136@pasky.ji.cz>
- In-Reply-To
- <7voebbpuxs.fsf@assigned-by-dhcp.cox.net>
Dear diary, on Mon, May 16, 2005 at 08:05:19AM CEST, I got a letter where Junio C Hamano <junkio@cox.net> told me that...
Show 22 quoted lines
> --- a/paths.c
> +++ b/paths.c
> @@ -0,0 +1,199 @@
> +static int initialize_ignore_list(void)
> +{
> + /* Put the Porcelain layer ignore logic initialization here.
> + * Return non-zero after issuing appropriate error message
> + * if initialization fails.
> + */
> + return 0;
> +}
> +
> +int path_ignored(const char *path)
> +{
> + if (!verify_path(path))
> + return 1;
> +
> + /* Put the Porcelain layer ignore logic here.
> + * Return non-zero if path is to be ignored.
> + */
> + return 0;
> +}I actually think you shouldn't. All the Porcelain layers should hopefully use the same git toolkit layer, not each one shipping own due to differences in things like this.
If we don't agree on something common (implemented in a way to be still circumventable by a porcelain layer if desired), I wouldn't put the ignore logic inside at all.
> +/****************************************************************/ > + > +/* Path canonicalization part */
And why is this in the library?
-- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor